Refactory readprob with functions usable for Julia wrapper - #12
Open
blegat wants to merge 3 commits into
Open
Conversation
11 tasks
Author
|
Anything I could do to help this PR move forward ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is currently quite difficult to use CSDP from another language as there is no API to play with the structures.
In Julia, we mirrored the C-structures and modify them in Julia, see
but this is quite tricky to make sure that the Julia GC does not free the memory used by CSDP and vice versa.
This is most probably the reason CSDP now often segfaults: Sporadic malloc errors with CSDP 4.1 jump-dev/CSDP.jl#39.
This PR adds an API in
lib/julia.cthat can be used by the Julia wrapper. The filereadprob.chas been refactoried on top of the API.The file
julia.cis heavily inspired fromreadprob.cto make sure that the behavior ofreadprob.cdoes not change and that this PR does not break anyone's code.The API in
lib/julia.ccould also be used by C users or wrappers from other languages, nothing is specific to Julia. We could rename itlib/api.cif you prefer.