Skip to content

Add validation for reverse connections pointing through reverse prope… - #1612

Open
poocog wants to merge 2 commits into
mainfrom
feat/reverse-relation-cycle-validator
Open

Add validation for reverse connections pointing through reverse prope…#1612
poocog wants to merge 2 commits into
mainfrom
feat/reverse-relation-cycle-validator

Conversation

@poocog

@poocog poocog commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Description

Detect when a reverse direct relation's through property is itself a reverse relation, including cyclic A↔B cases, with a clear error explaining the mapping never resolves to a container. De-duplicate REVERSE-003 for this case and add snapshot tests.

Bump

  • Patch
  • Skip

Changelog

Added/Changed/Improved/Removed/Fixed

  • Add NEAT-DMS-CONNECTIONS-REVERSE-010 (ReverseConnectionThroughPropertyIsReverse) to detect when a reverse direct relation points through another reverse property instead of a direct relation that maps to a container.
  • Report cyclic reverse connection paths (e.g. A↔B) in the error message to make large-model debugging easier.
  • De-duplicate REVERSE-003 for reverse-through-reverse cases and add snapshot/integration tests.

…rties

Detect when a reverse direct relation's through property is itself a reverse relation, including cyclic A↔B cases, with a clear error explaining the mapping never resolves to a container. De-duplicate REVERSE-003 for this case and add snapshot tests.

Co-authored-by: Cursor <cursoragent@cursor.com>
@poocog
poocog requested a review from a team as a code owner August 3, 2026 09:59
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant