Skip to content

feat: configurable zoom limits - #35

Open
MightyCoderX wants to merge 1 commit into
coffeeispower:mainfrom
MightyCoderX:feat-configurable-zoom-limits
Open

feat: configurable zoom limits#35
MightyCoderX wants to merge 1 commit into
coffeeispower:mainfrom
MightyCoderX:feat-configurable-zoom-limits

Conversation

@MightyCoderX

Copy link
Copy Markdown
  • constants to define default zoom min, max, and speed values
  • use logarithms to adapt to any MIN/MAX_ZOOM values automatically
  • cli args to configure zoom min, max and speed
  • update help message accordingly

- constants to define default zoom min, max, and speed values
- use logarithms to adapt to any MIN/MAX_ZOOM values automatically
- cli args to configure zoom min, max and speed
- update help message accordingly
@MightyCoderX

Copy link
Copy Markdown
Author

I know there are a lot of unwraps there but I'm not too good with rust, if you could suggest me what the proper way to replace that unwrap with a safe handling I'll do that ASAP

@coffeeispower

Copy link
Copy Markdown
Owner

You should probably handle those errors because they are parse errors and it will panic if you pass something that is not a number. Javascript would return you NaN when you do Number.parse(), but in rust it returns you a proper Result::Err that you can easily handle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants