feat: configurable zoom limits - #35
Open
MightyCoderX wants to merge 1 commit into
Open
Conversation
MightyCoderX
commented
Jun 4, 2026
- constants to define default zoom min, max, and speed values
- use logarithms to adapt to any MIN/MAX_ZOOM values automatically
- cli args to configure zoom min, max and speed
- update help message accordingly
- constants to define default zoom min, max, and speed values - use logarithms to adapt to any MIN/MAX_ZOOM values automatically - cli args to configure zoom min, max and speed - update help message accordingly
Author
|
I know there are a lot of unwraps there but I'm not too good with rust, if you could suggest me what the proper way to replace that unwrap with a safe handling I'll do that ASAP |
Owner
|
You should probably handle those errors because they are parse errors and it will panic if you pass something that is not a number. Javascript would return you NaN when you do Number.parse(), but in rust it returns you a proper Result::Err that you can easily handle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.