[Test Improver] Add unit tests for dynamic content notification-handler - #93
Draft
github-actions[bot] wants to merge 1 commit into
Draft
[Test Improver] Add unit tests for dynamic content notification-handler#93github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Add 15 unit tests for createHandler/onReadUpdated in shell/utils/dynamic-content/notification-handler.ts achieving 100% statement/branch/function/line coverage. Tests cover: - Returns early for non-announcement notification IDs - Dispatches prefs/set for valid announcement notifications - Strips ANNOUNCEMENT_PREFIX before storing in pref - Marks notification as read: adds stripped ID to pref - Marks notification as unread: removes stripped ID from pref - Handles empty pref value (no existing entries) - Deduplicates IDs via Set (no double-entry on re-read) - Sorts resulting IDs alphabetically before dispatching - Unread of absent ID leaves pref unchanged - Handles null pref value (same as empty string) - Stores multi-part IDs (e.g. release-2.8.0-important) correctly Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Test Improver, an automated AI assistant focused on improving test coverage.
Goal and Rationale
shell/utils/dynamic-content/notification-handler.tsprovides thecreateHandlerfactory and theonReadUpdatedcallback that manages the "read announcements" user preference. This is the core mechanism for tracking which dynamic content announcements a user has already dismissed — a user-facing feature with no existing test coverage.Approach
15 unit tests covering all branches of
onReadUpdated:''nullpref (same as empty string)release-2.8.0-important)Coverage Impact
notification-handler.tsTest Commands
Test Status
✅ All 15 tests pass, 0 lint warnings.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
download.cypress.ioSee Network Configuration for more information.