[Test Improver] Add unit tests for growl store - #85
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Conversation
Add 25 unit tests covering state factory, getters (find, byId), mutations (add, remove, clear), and actions (close, notification) for shell/store/growl.js. Highlights: - add mutation: MAX_GROWLS=5 overflow → oldest item evicted - close action: conditional notifications/markRead dispatch - notification action: NotificationLevel → color/icon mapping, skip for Announcement/Task/Info/Hidden levels Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
26 tasks
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Test Improver, an automated AI assistant focused on improving test coverage.
Goal and Rationale
Add unit tests for
shell/store/growl.js. The growl store manages transient notification banners and contains non-trivial logic that was completely untested:addmutation — enforces aMAX_GROWLS = 5cap (evicts the oldest on overflow) and prepends new items with an auto-incremented id and a timestampcloseaction — conditionally dispatchesnotifications/markReadonly when the growl carries a linked notification idnotificationaction — mapsNotificationLevelvalues to color/icon pairs and skips levels that don't warrant a growl (Announcement, Task, Info, Hidden)These rules are easy to break accidentally — the tests codify and guard them.
Approach
find/byIdgetters, all three mutations, and theclose/notificationactions{ commit, dispatch, getters }mocksnotificationaction usesit.eachto cover all four skipped levels and all three committed levelsCoverage Impact
shell/store/growl.jsTest Status
✅ 25 tests pass, 0 failures, 0 lint warnings
Reproducibility
yarn test:ci --testPathPattern='shell/store/__tests__/growl.test.ts'Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
download.cypress.ioSee Network Configuration for more information.