[Test Improver] Add unit tests for action-menu store - #81
Draft
github-actions[bot] wants to merge 1 commit into
Draft
[Test Improver] Add unit tests for action-menu store#81github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Add 34 unit tests for shell/store/action-menu.js covering: - State factory default values - optionsArray getter: empty/null resources, single resource, multi-resource action merging, enabled/disabled logic, deduplification, anyEnabled filtering - show/hide mutations including single-to-array normalization - togglePromptRemove / togglePromptRestore mutations - togglePromptModal: falsy clear path, performCallback path, showModal path - updateModalData key/value merge - clearCallbackData and SET_RESOURCE mutations - execute action: per-resource dispatch, skip missing, altAction/altResource path - setResource and clearCallbackData actions Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
26 tasks
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Test Improver, an automated AI assistant focused on improving test coverage.
Goal and Rationale
Add unit tests for
shell/store/action-menu.js. This store manages the context-menu/action-menu UI state and contains non-trivial logic that was completely untested:optionsArraygetter — builds a merged action list from multiple selected resources, tracking per-actionavailable/totalcounts to compute the finalenabledstatetogglePromptModalmutation — three distinct code paths (clear,performCallback, show-modal)executeaction — dispatches to per-resource action functions, supportsaltAction/altResourcesubstitutiontogglePromptRemove,togglePromptRestore,SET_RESOURCE)Approach
state,getters,mutations, andactionsdirectly from the module for isolated unit testing (no Vuex runtime)optionsArraythroughresourcesshapes to verify the_add/_filterhelper logic indirectlyCoverage Impact
shell/store/__tests__/action-menu.test.tsTrade-offs
state,getters,mutations,actions). The private_add/_filter/_executehelpers are exercised indirectly throughoptionsArrayandexecute.available/totalcomparison).Reproducibility
YARN_IGNORE_ENGINES=true NODE_OPTIONS=--max_old_space_size=8192 yarn test:ci --testPathPattern="shell/store/__tests__/action-menu"Test Status
✅ All 34 tests pass. No linting warnings.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
download.cypress.ioSee Network Configuration for more information.