[Test Improver] Add unit tests for uiplugins store - #69
Draft
github-actions[bot] wants to merge 1 commit into
Draft
[Test Improver] Add unit tests for uiplugins store#69github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Cover state factory, all mutations (setError, addPlugin, removePlugin, setReady) and pass-through getters. Notable cases: - removePlugin: no-op when name absent, removes only first duplicate match, removes mid-list entry without disturbing others - setError: overwrites existing entries, stores falsy values Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
26 tasks
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Test Improver, an automated AI assistant focused on improving test coverage.
Goal and Rationale
Add unit tests for
shell/store/uiplugins.ts. This store manages UI plugin registration (add, remove, track load errors, readiness). It had zero test coverage despite theremovePluginmutation containing meaningful index-search-and-splice logic worth protecting.Approach
state,getters, andmutationsdirectly from the store modulePluginStubinterface ({ name: string }) cast asPluginto avoid constructing the full classcommit()wrappers)Tests written (19 total):
stategettersplugins,errors,readyreturn corresponding state slicesmutations.setErrormutations.addPluginmutations.removePluginmutations.setReadyCoverage Impact
New file:
shell/store/__tests__/uiplugins.test.ts(19 tests). The uiplugins store module was previously uncovered.Trade-offs
setError,addPlugin,removePlugin,setReady) omitted — all are one-linecommit()wrappers with no branching logic.Reproducibility
Test Status
✅ All 19 tests pass. ESLint reports no warnings.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
download.cypress.ioSee Network Configuration for more information.