[Test Improver] Add unit tests for slideInPanel store - #65
Draft
github-actions[bot] wants to merge 1 commit into
Draft
[Test Improver] Add unit tests for slideInPanel store#65github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Add 12 unit tests covering the slideInPanel Vuex store:
- state factory: correct initial values (isOpen, isClosing, component, componentProps)
- mutations.open: sets isOpen, stores component, defaults componentProps to {},
uses provided componentProps
- mutations.close: immediately sets isOpen=false and isClosing=true,
defers component/componentProps/isClosing reset to 500ms (via fake timers)
- namespaced: confirms namespaced flag
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
26 tasks
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Test Improver, an automated AI assistant focused on improving test coverage.
Goal and Rationale
Add unit tests for
shell/store/slideInPanel.ts. This store manages the slide-in panel UI element (visibility, animation state, and component rendering). It had zero test coverage despite containing meaningful mutation logic — particularly the deferred cleanup in theclosemutation.Approach
Tested at the unit level by calling the state factory and mutations directly (no Vuex store instantiation required):
state: Verify the factory returns correct initial defaults.mutations.open: VerifyisOpenis set, component is stored, andcomponentPropsdefaults to{}or uses provided value.mutations.close:isOpen = false,isClosing = true(transition begins).component = null,componentProps = {},isClosing = false.jest.useFakeTimers()/jest.advanceTimersByTime(500)to verify the timeout behaviour.namespaced: Confirm the store is namespaced.Getters were intentionally not tested — they are trivial one-liner state accessors (no logic).
Coverage Impact
slideInPanel.ts(before)slideInPanel.ts(after)Trade-offs
setTimeoutinclosefrom real-world timing.Reproducibility
Test Status
✅ 12/12 tests pass · ✅ ESLint clean (0 warnings)
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
download.cypress.ioSee Network Configuration for more information.