[Test Improver] Add unit tests for notifications store actions - #53
Draft
github-actions[bot] wants to merge 1 commit into
Draft
[Test Improver] Add unit tests for notifications store actions#53github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Cover markRead, markUnread, markAllRead, and init actions with 20 new tests. Key branches exercised: - markRead/markUnread: commit path, prefs/set dispatch (with and without unsetValue), extension handler invocation (read=true/false) - markAllRead: no-pref/handler case, multi-notification prefs dispatch, multi-notification handler invocation - init: early-return on missing userKey/userId, early-return on deriveKey failure, full happy path (empty and non-empty localStorage), expired-notification filtering, per-notification decrypt failure, BroadcastChannel onmessage with matching and non-matching userId Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
26 tasks
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Test Improver — automated AI assistant
Goal and Rationale
shell/store/notifications.tsalready has a pending PR (#40) covering mutations and getters. The actions layer (markRead,markUnread,markAllRead, andinit) had zero test coverage despite containing meaningful branching logic:markRead/markUnread: conditionalprefs/setdispatch and extension handler invocationmarkUnread:unsetValuefallback to empty string when unsetmarkAllRead: iterates over all notifications, dispatching prefs and invoking handlers for eachinit: 7 distinct code paths — missing user data early returns,deriveKeyfailure, happy path (empty + non-empty localStorage), expired-notification filtering, per-notification decrypt failure, BroadcastChannel message filtering by userIdApproach
@shell/utils/crypto/encryption(deriveKey,decrypt,encrypt) to avoidSubtleCryptounavailability in jsdom@shell/utils/crypto(md5) for deterministic hash outputBroadcastChannelglobally per test to isolate module-levelbcstate.call({ $extension: mockExtension }, ...)to inject thethis.$extensioncontext required bycallNotifyHandlerCoverage Impact
shell/store/notifications.ts(actions)markRead,markUnread,markAllRead,init— all major branchesTest Status
✅ All 20 new tests pass
✅ ESLint clean (
--max-warnings 0)Reproducibility
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
download.cypress.ioSee Network Configuration for more information.