[Test Improver] Add unit tests for features store - #128
Draft
github-actions[bot] wants to merge 1 commit into
Draft
[Test Improver] Add unit tests for features store#128github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Cover the features store's get getter (unknown feature throw, entry-found and fallback-to-default paths), loadServer action (dispatch guarded by canList), and mapFeature helper (get delegates to store getter, set always throws). 11 tests across 4 describe blocks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Test Improver, an automated AI assistant focused on improving test coverage.
Goal and Rationale
shell/store/features.jshad zero test coverage. This store is a critical piece of Rancher's feature-flag system — it controls whether features like multi-cluster management, RKE2, Fleet, and Harvester are active. Thegetgetter has meaningful branching logic (unknown feature throws, found entry wins over default, fallback to registered default), making it a good target for regression protection.Approach
getters.getacross all three code paths: unknown feature name (throws), feature entry exists in management store (returnsentry.enabled), and no entry (falls back to registered default)actions.loadServerfor both the guarded and unguarded paths (canListtrue vs. false), and that it returns thefindAllresultmapFeaturehelper:get()delegates to the store getter with the correct feature name;set()always throwsTable-driven
it.eachused for the entry-enabled/disabled cases and the fallback-default cases.Coverage Impact
features.jsstatementsfeatures.jsfunctionsfeatures.jsbranchesTrade-offs
definitionsobject is module-level state, populated at import time by thecreate(...)calls. Tests use the pre-registered constants (MULTI_CLUSTER,LEGACY,RKE2) directly — no mocking of module internals needed.mapFeature.get()is a Vue computed helper tested with.call(context)rather than a full component mount, keeping tests lightweight.Reproducibility
Test Status
✅ 11 tests passing, 0 failures, 0 lint warnings
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
download.cypress.ioSee Network Configuration for more information.