[Test Improver] Add unit tests for AcceptOrRejectSocketMessage - #114
Draft
github-actions[bot] wants to merge 1 commit into
Draft
[Test Improver] Add unit tests for AcceptOrRejectSocketMessage#114github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Test the class that filters WebSocket resource changes against the active namespace cache and paginated page state. - typeIsNamespaced: non-empty vs empty/undefined haveNamespace result - typeIsPaginated: truthy vs falsy havePage result - filteredNamespaces: returns activeNamespaceCache - subscribeNamespace: non-empty array → undefined (sub to all); empty array → [] - validChange: non-ns/non-paginated → true; ns in cache → true; ns missing → false; paginated id found → true; paginated id missing → false; ns-then-pagination precedence - validateBatchChange: no filter; ns filter removes out-of-scope entries; pagination filter removes missing ids; non-namespaced schema skips ns check; per-type caching (haveNamespace/havePage called once per type) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Test Improver, an automated AI assistant focused on improving test coverage.
Goal and Rationale
shell/plugins/steve/accept-or-reject-socket-message.tshad no test coverage. This class is responsible for deciding which WebSocket messages the Steve store should accept or reject — a critical correctness boundary for real-time resource updates. It has multiple branches across 6 methods:typeIsNamespaced/typeIsPaginated: detect whether a resource type is namespace-scoped or paginatedfilteredNamespaces: returns the active namespace cache from the root storesubscribeNamespace: decides whether to subscribe to all changes (returnsundefined) or a specific namespace listvalidChange: validates a single resource change against namespace and pagination filtersvalidateBatchChange: filters an entire batch of WebSocket changes, caching per-type lookups for efficiencyApproach
makeCtxhelper to produce mock{ getters, rootGetters }objects, keeping test setup minimal.export defaultdirectly — no module-level mocking needed since the class holds no internal state.jest.fn()for all getter functions to assert delegation and call counts.Tests (23 total)
typeIsNamespacedtypeIsPaginatedfilteredNamespacesactiveNamespaceCachesubscribeNamespace[]validChangevalidateBatchChangeCoverage Impact
accept-or-reject-socket-message.tsmoves from 0% → ~100% statement/branch coverage across all 6 methods.Trade-offs
Reproducibility
Test Status
✅ All 23 tests pass. ESLint: 0 warnings.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
download.cypress.ioSee Network Configuration for more information.