Skip to content

fix(tui): say "no matches" in the /mcp status line when a search finds nothing - #7023

Merged
Hmbown merged 1 commit into
codewhale-hq:mainfrom
Lstarsky0:ux/extensions-no-match-status
Oct 18, 2026
Merged

Hmbown merged 1 commit into
codewhale-hq:mainfrom
Lstarsky0:ux/extensions-no-match-status

Conversation

@Lstarsky0

Copy link
Copy Markdown
Contributor

What and why

Searching the Extensions panel (/mcp) for something that isn't there makes the list and the status line under it disagree. At 80×24, after / and zzqx on the MCP tab, before:

  Search: zzqx_
  No matches for 'zzqx'
  ...
  Nothing on this tab

After:

  Search: zzqx_
  No matches for 'zzqx'
  ...
  No matches for 'zzqx'

The MCP tab has a row; the search only hides it. The list already picks between "Nothing on this tab" and "No matches for '{query}'" by whether a query is set, but selected_status always used the first one. Both now come from one small helper, so the status line says what the list says. With no query nothing changes.

Issue

No-Issue: /mcp status line contradicts the list during a search, no issue filed for it

How I tested it

  • Ran a debug build in a pseudo-terminal with an empty HOME, opened /mcp, pressed / and typed zzqx, then pressed Tab to the Hooks tab (the query carries over), at 80×24 and 60×16, with this change and with a build from before it. In all four screens the status line is the only row that differs.
  • cargo fmt --all -- --check, cargo clippy -p codewhale-tui --all-targets --all-features with CI's flags, and cargo check -p codewhale-tui --all-targets: clean. Clippy also on 1.99, plus cargo +1.89.0 check -p codewhale-tui.
  • cargo nextest run -p codewhale-tui --lib: 15349 passed, none failed.

Checklist

  • One focused change, on eeb3f46; it merges cleanly into current main
  • cargo fmt --all passes, and tests cover new or changed behavior
  • If this adds or changes a user-facing feature, I updated its docs and its row in docs/features.toml (cargo test -p codewhale-tui --test feature_registry checks it) — n/a

…s nothing

Searching the Extensions panel for something that isn't there makes the
list say "No matches for 'zzqx'", while the status line under it says
"Nothing on this tab", on a tab that has rows and only hides them while
the search runs. The list picks between the two messages by whether a
query is set; the status line always took the empty-tab one.

Pick the message in one place and use it for both, so the status line
says what the list says.

Signed-off-by: Lstarsky0 <59827030+Lstarsky0@users.noreply.github.com>
@Lstarsky0
Lstarsky0 requested a review from Hmbown as a code owner October 18, 2026 16:55

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@github-actions github-actions Bot added the contribution-gate Author not yet in .github/APPROVED_CONTRIBUTORS; a maintainer grants access with /lgtm label Oct 18, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T16:58:55.959568Z 48230b8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Hmbown
Hmbown merged commit 7553ba1 into codewhale-hq:main Oct 18, 2026
28 checks passed
@Hmbown

Hmbown commented Oct 18, 2026

Copy link
Copy Markdown
Collaborator

🤖 Claude Opus 5.5, working for the maintainer.

Thanks, @Lstarsky0. The status line and the list now share one source for the empty message, so a search that finds nothing says the same thing in both places. Merged.

🤖 Generated by Claude Opus 5.5 for the Codewhale maintainers.

Hmbown pushed a commit that referenced this pull request Oct 18, 2026
#7023 (/mcp status line says "No matches" during an empty search) merged
as 7553ba1; #7024 (scroll rail on /settings choice lists that don't
fit) merged after its branch was updated past the clippy fix in
37a596b. Both changelogs get the same entries.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NBKbhx19BRbZtvWK8rVKjz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution-gate Author not yet in .github/APPROVED_CONTRIBUTORS; a maintainer grants access with /lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants