Repository navigation
fix(tui): say "no matches" in the /mcp status line when a search finds nothing - #7023
Merged
Hmbown merged 1 commit intoOct 18, 2026
Merged
Conversation
…s nothing Searching the Extensions panel for something that isn't there makes the list say "No matches for 'zzqx'", while the status line under it says "Nothing on this tab", on a tab that has rows and only hides them while the search runs. The list picks between the two messages by whether a query is set; the status line always took the empty-tab one. Pick the message in one place and use it for both, so the status line says what the list says. Signed-off-by: Lstarsky0 <59827030+Lstarsky0@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
Thanks, @Lstarsky0. The status line and the list now share one source for the empty message, so a search that finds nothing says the same thing in both places. Merged.
|
Hmbown
pushed a commit
that referenced
this pull request
Oct 18, 2026
#7023 (/mcp status line says "No matches" during an empty search) merged as 7553ba1; #7024 (scroll rail on /settings choice lists that don't fit) merged after its branch was updated past the clippy fix in 37a596b. Both changelogs get the same entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NBKbhx19BRbZtvWK8rVKjz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Searching the Extensions panel (/mcp) for something that isn't there makes the list and the status line under it disagree. At 80×24, after
/andzzqxon the MCP tab, before:After:
The MCP tab has a row; the search only hides it. The list already picks between "Nothing on this tab" and "No matches for '{query}'" by whether a query is set, but
selected_statusalways used the first one. Both now come from one small helper, so the status line says what the list says. With no query nothing changes.Issue
No-Issue: /mcp status line contradicts the list during a search, no issue filed for it
How I tested it
/mcp, pressed/and typedzzqx, then pressed Tab to the Hooks tab (the query carries over), at 80×24 and 60×16, with this change and with a build from before it. In all four screens the status line is the only row that differs.cargo fmt --all -- --check,cargo clippy -p codewhale-tui --all-targets --all-featureswith CI's flags, andcargo check -p codewhale-tui --all-targets: clean. Clippy also on 1.99, pluscargo +1.89.0 check -p codewhale-tui.cargo nextest run -p codewhale-tui --lib: 15349 passed, none failed.Checklist
maincargo fmt --allpasses, and tests cover new or changed behaviordocs/features.toml(cargo test -p codewhale-tui --test feature_registrychecks it) — n/a