Skip to content

test(subagent): widen three short approval bounds to 30 s #6966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hmbown merged 2 commits into from
Oct 14, 2026
Merged

test(subagent): widen three short approval bounds to 30 s #6966

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f975da
test(subagent): three private approval bounds use the shared readines…
Lstarsky0 Oct 12, 2026
e98ef95
test(subagent): the fail-closed bound keeps its own 30 s
Lstarsky0 Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/tui/src/tools/subagent/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24386,7 +24386,7 @@ mod child_permission_gate {
registry.gate_runtime.approval_receipt_store = None;

let result = tokio::time::timeout(
std::time::Duration::from_millis(250),
std::time::Duration::from_secs(30),
registry.execute("agent_gate", "bash", json!({"command": "echo gated"})),
)
.await
Expand Down Expand Up @@ -24583,7 +24583,7 @@ mod child_permission_gate {
let expected = child_approval_keys("agent_gate", "bash", &input);
let manager_for_answer = Arc::clone(&manager);
let answerer = tokio::spawn(async move {
tokio::time::timeout(std::time::Duration::from_secs(2), async {
tokio::time::timeout(CHILD_APPROVAL_EVENT_READINESS, async {
while let Some(event) = rx.recv().await {
if let Event::ApprovalRequired {
id,
Expand Down Expand Up @@ -24891,7 +24891,7 @@ mod child_permission_gate {
"retirement waits for channel capacity instead of dropping the event"
);
assert!(matches!(rx.recv().await, Some(Event::Status { .. })));
tokio::time::timeout(Duration::from_secs(1), delivery)
tokio::time::timeout(CHILD_APPROVAL_EVENT_READINESS, delivery)
.await
.expect("retirement is delivered once the host drains");
assert!(matches!(
Expand Down
Loading