Repository navigation
fix(coro): global_switch runs on and off under a mutex - #20
Merged
Merged
Conversation
- an acquire returns after on finished, on and off never overlap - a throw of on leaves the count unchanged, the next acquire calls on again - tests for the three cases, they fail with the old atomic counter
codethinki
enabled auto-merge (squash)
October 21, 2026 11:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The atomic counter alone was not thread safe and not exception safe.
Problems:
Fix:
Tests: 5 new tests in `global_switch_test.cpp`. The 3 tests for the problems fail with the old code.
Found while using the switch for the vulkan loader in cth_engine.