Skip to content

SANDBOX-1889: change default phoneLookupMode from log to disabled #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fbm3307 wants to merge 1 commit into from
Closed

SANDBOX-1889: change default phoneLookupMode from log to disabled #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/v1alpha1/docs/apiref.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2339,7 +2339,7 @@ See https://docs.aws.amazon.com/sns/latest/dg/sms_publish-to-phone.html for deta

| *`phoneLookupMode`* __xref:{anchor_prefix}-github-com-codeready-toolchain-api-api-v1alpha1-phonelookupmode[$$PhoneLookupMode$$]__ | PhoneLookupMode controls how the registration service handles Twilio Lookup v2 phone risk checks. +
Valid values are "disabled" (skip Lookup entirely), "log" (call Lookup and store results but don't block), +
and "enabled" (call Lookup and enforce blocking). Defaults to "log". + | log | Enum: [disabled log enabled] +
and "enabled" (call Lookup and enforce blocking). Defaults to "disabled". + | disabled | Enum: [disabled log enabled] +
Optional: \{} +

| *`phoneLookupExcludedCountries`* __string array__ | PhoneLookupExcludedCountries is a list of ISO 3166-1 alpha-2 country codes (e.g. ["CA", "US"]) +
Expand Down
4 changes: 2 additions & 2 deletions api/v1alpha1/toolchainconfig_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,9 +399,9 @@ type RegistrationServiceVerificationConfig struct {

// PhoneLookupMode controls how the registration service handles Twilio Lookup v2 phone risk checks.
// Valid values are "disabled" (skip Lookup entirely), "log" (call Lookup and store results but don't block),
// and "enabled" (call Lookup and enforce blocking). Defaults to "log".
// and "enabled" (call Lookup and enforce blocking). Defaults to "disabled".
// +optional
// +kubebuilder:default="log"
// +kubebuilder:default="disabled"
PhoneLookupMode *PhoneLookupMode `json:"phoneLookupMode,omitempty"`

// PhoneLookupExcludedCountries is a list of ISO 3166-1 alpha-2 country codes (e.g. ["CA", "US"])
Expand Down
2 changes: 1 addition & 1 deletion api/v1alpha1/zz_generated.openapi.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading