test: migrate Docker orchestration to testcontainers-go#374
Conversation
71f5067 to
0a754e2
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a754e2e19
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0a754e2 to
1503379
Compare
|
@codex review re: Bind the Coder test port to loopback Thanks — I dug into this. You're right that the old hand-rolled Docker setup explicitly bound the published Coder port to I don't think we should take the loopback binding change as part of this migration, though. The idiomatic testcontainers API here is The practical risk seems acceptable for this test harness: the instance is ephemeral, uses a random host port, is short-lived, and runs inside the test runner environment. If we want localhost-only published ports as a hard security requirement, I think that should be a separate hardening change with explicit handling for testcontainers host resolution across Docker environments. I did keep the other fix from this review: cleanup and failure log collection are now registered immediately after |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1503379828
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1503379 to
734112b
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
734112b to
a250398
Compare
6e87fa3 to
6d0f35e
Compare
a250398 to
d21063f
Compare
6d0f35e to
10d7ae1
Compare
d21063f to
90a4bed
Compare
10d7ae1 to
c01d606
Compare
90a4bed to
eb217fe
Compare
c01d606 to
ee92aa7
Compare
eb217fe to
d037fee
Compare
ee92aa7 to
f01d658
Compare
d037fee to
3aecfb7
Compare
f01d658 to
3ed74ae
Compare
3aecfb7 to
bc80b0c
Compare
bc80b0c to
e61034a
Compare
3ed74ae to
382af33
Compare
Merge activity
|
e61034a to
7c1cbed
Compare
382af33 to
837564e
Compare
7c1cbed to
e04e7f9
Compare

Replaces the hand-rolled Docker SDK container lifecycle in
integration/integration.gowithtestcontainers-go.StartCoder's signature and all its options are unchanged, so the acceptance and integration test callsites are untouched.testcontainers handles image pulls, the mapped host port, readiness waiting, and cleanup, which lets us delete the
pullImageandrandomPorthelpers and dropdocker/dockeras a direct dependency.Closes PLAT-367.