🤖 tests: stabilize settings experiment stories#3562
Merged
Conversation
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ThomasK33
force-pushed
the
chromatic-tests-n7yc
branch
from
16ffabc to
e211589
Compare
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stabilizes the Settings → Experiments Storybook snapshots by clearing experiment localStorage overrides before each settings section story setup, while still allowing individual stories to seed the experiments they need.
Background
The PTC toggle in the Heartbeat Settings Enabled Chromatic snapshot could inherit
experiment:programmatic-tool-callingfrom theExperimentsToggleOnstory because Storybook/Chromatic reuse the same browser origin across story renders.Implementation
setupSettingsStory()so stories can opt back into required toggle states.Validation
bun test src/browser/features/Settings/Sections/settingsStoryUtils.test.tsxbun test src/browser/features/Settings/Sections/*.test.tsxMUX_ESLINT_CONCURRENCY=1 make static-checkbun x test-storybook --url http://localhost:6006 --testTimeout 30000 --maxWorkers=2Risks
Low. This only affects the shared Storybook wrapper for settings section stories. Production experiment persistence remains unchanged, and stories can still seed explicit experiment values through
setupSettingsStory().Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:$8.46