Skip to content

🤖 perf: short-circuit no-issue deep reviews#3561

Merged
ThomasK33 merged 2 commits into
mainfrom
review-workflow-x3z7
Jun 15, 2026
Merged

🤖 perf: short-circuit no-issue deep reviews#3561
ThomasK33 merged 2 commits into
mainfrom
review-workflow-x3z7

Conversation

@ThomasK33

Copy link
Copy Markdown
Member

Summary

Short-circuits deep-review workflow runs when earlier phases prove there are no actionable findings, avoiding unnecessary triage, verification, and final-synthesis agents.

Background

A no-issue review currently still spends extra agent turns on dedupe/triage and final reporting. This keeps the structured result shape but exits as soon as no later agent can add value.

Implementation

  • Return a deterministic “No verified issues” result when review lanes emit zero issues.
  • Skip verification/final synthesis when triage drops every candidate.
  • Skip final synthesis when adversarial verification upholds no candidates.
  • Share final pass handling so review-only, --fix, and --loop behavior remain consistent.
  • Regenerate embedded built-in workflow content.

Validation

  • make static-check
  • bun scripts/gen_builtin_workflows.ts check
  • bun test src/node/services/workflows/builtInWorkflowDefinitions.test.ts -t "built-in deep-review-workflow"
  • make typecheck
  • make lint
  • make fmt-check
  • git diff --check

Risks

Low-to-medium workflow orchestration risk: this changes which phases are recorded in no-issue paths, but preserves the existing structured output shape and adds regression coverage for the skipped-agent behavior.


Generated with mux • Model: openai:gpt-5.5 • Thinking: xhigh • Cost: $7.63

@ThomasK33

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d4876bb9b8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/node/builtinWorkflows/deep-review-workflow.js Outdated
@ThomasK33

Copy link
Copy Markdown
Member Author

@codex review

Please take another look after the overstated-verdict fix.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 5494503053

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ThomasK33 ThomasK33 added this pull request to the merge queue Jun 15, 2026
Merged via the queue into main with commit 0c2f6d3 Jun 15, 2026
40 of 42 checks passed
@ThomasK33 ThomasK33 deleted the review-workflow-x3z7 branch June 15, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant