fix: improve show all scrolling logic#249
Draft
jakehwll wants to merge 2 commits into
Draft
Conversation
The previous assertion used find(ViewType.Button.self), which also matches the expand button inside MenuItemView. Switch to find(button: "Show all") so the assertions target the Show all affordance specifically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-request implements some cool chevrons and a mask around our
Show allandShow lesslogic. This aims to make things feel a bit more native. Furthermore, we've added an icon to theShow alland converted it to a button to increase the hit target. ✨