Skip to content

pull maxmsp-ts into monorepo until original is compatible - #22

Merged
codekiln merged 3 commits into
mainfrom
codekiln/issue20-pull-maxmsp-ts-into-monorepo-until-original-is-compatible
Feb 11, 2025
Merged

pull maxmsp-ts into monorepo until original is compatible#22
codekiln merged 3 commits into
mainfrom
codekiln/issue20-pull-maxmsp-ts-into-monorepo-until-original-is-compatible

Conversation

@codekiln

@codekiln codekiln commented Feb 11, 2025

Copy link
Copy Markdown
Owner

Fixes #20

This PR temporarily pulls maxmsp-ts into our monorepo to address Max for Live compatibility issues until aptrn/maxmsp-ts#28 is resolved or aptrn/maxmsp-ts#29 is merged.

Why

Currently, our CI builds are failing because they can't access the correct version of maxmsp-ts that supports compiling assets to the root directory for Max for Live compatibility. This is blocking development and CI pipelines.

Changes

  • Adds maxmsp-ts package to monorepo workspace
  • Updates kebricide to use workspace version (@codekiln/maxmsp-ts: "workspace:*") instead of external dependency
  • Maintains compatibility with Max for Live by allowing compilation to root directory

Migration Plan

Once aptrn/maxmsp-ts#28 is fixed or PR #29 is merged upstream, we will:

  1. Remove the local maxmsp-ts package
  2. Switch back to using the npm published version
  3. Update all dependent packages accordingly

Testing

  • Verify CI builds pass with workspace version
  • Confirm Max for Live compatibility works
  • Test kebricide builds with workspace dependency

Related Issues

This is a temporary solution until upstream changes are merged.

WARNING  no output files found for task kebricide#build. Please check your `outputs` key in `turbo.json`
 WARNING  no output files found for task maxmsp-test#build. Please check your `outputs` key in `turbo.json`
@codekiln
codekiln merged commit 6dc5315 into main Feb 11, 2025
@codekiln
codekiln deleted the codekiln/issue20-pull-maxmsp-ts-into-monorepo-until-original-is-compatible branch February 11, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pull maxmsp-ts into monorepo until original is compatible

1 participant