pull maxmsp-ts into monorepo until original is compatible - #22
Merged
codekiln merged 3 commits intoFeb 11, 2025
Merged
Conversation
WARNING no output files found for task kebricide#build. Please check your `outputs` key in `turbo.json` WARNING no output files found for task maxmsp-test#build. Please check your `outputs` key in `turbo.json`
codekiln
deleted the
codekiln/issue20-pull-maxmsp-ts-into-monorepo-until-original-is-compatible
branch
February 11, 2025 10:41
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20
This PR temporarily pulls maxmsp-ts into our monorepo to address Max for Live compatibility issues until aptrn/maxmsp-ts#28 is resolved or aptrn/maxmsp-ts#29 is merged.
Why
Currently, our CI builds are failing because they can't access the correct version of maxmsp-ts that supports compiling assets to the root directory for Max for Live compatibility. This is blocking development and CI pipelines.
Changes
@codekiln/maxmsp-ts: "workspace:*") instead of external dependencyMigration Plan
Once aptrn/maxmsp-ts#28 is fixed or PR #29 is merged upstream, we will:
Testing
Related Issues
This is a temporary solution until upstream changes are merged.