ci: add workflow_dispatch to allow on-demand runs (browser SonarQube scan)#61
Merged
Conversation
… demand The CI workflow only triggered on push/PR to main, so there was no way to re-run the browser-SDK SonarQube scan without pushing a commit (e.g. to test a SonarCloud project/setting change). Add a workflow_dispatch trigger (`gh workflow run ci.yml --ref main`) and extend the SonarQube step's guard to fire on manual runs too — otherwise the existing push/same-repo-PR condition would skip the scan on a dispatch run. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
workflow_dispatchtrigger to the CI workflow so it can be run on demand against any ref:Why
The workflow only fired on
push/pull_requesttomain, so there was no way to re-trigger the browser-SDK SonarQube scan without pushing a commit. This is needed to test SonarCloud project/setting changes (see #60) without churning commits.Also
The SonarQube step's
if:guard (pushor same-repo PR) would have skipped the scan on aworkflow_dispatchrun, so it's extended to includegithub.event_name == 'workflow_dispatch'. Manual and push runs both haveSONAR_TOKENavailable; fork PRs are still excluded.No other behavior changes.
🤖 Generated with Claude Code