Add sonarqube

[bernata]

@wolpert Just checking if you created the sonarqube project with the community edition and added the token. I'm finding failures here. I couldn't find the project on sonarcloud.io/explore/projects so i just wondered if it had been created?

[wolpert]

Not yet... irl intrudes.... but I will soon

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[wolpert]

I'm still setting up sonarqube.... more happening

[wolpert]

So I got sonarqube in there, but it is f'ing annoying. Trying to decide if I should do configuration with it or not. I'm working on fixes currently.

[wolpert]

So I did the sonarqube thing... and it's there for java but not sure what to do for the javascript side. Do I create a new project that is only javascript?

I am kinda annoyed at the fake issues it finds in java land...

[wolpert]

@bernata okay, I'm annoyed... I'm pulling out sonarqube for java. Incoming ADR saying why. We can use it for javascript. But it's such an annoying thing to maintain for this.

[bernata]

@bernata okay, I'm annoyed... I'm pulling out sonarqube for java. Incoming ADR saying why. We can use it for javascript. But it's such an annoying thing to maintain for this.

@wolpert Ok. I have seen sonarqube be overly nit picky. But there should exist a reasonable set of rules for style + basic correctness.

How about these options [pick one or more]

• Re-enable sonarqube for java and I [or i suppose you] go through the ruleset and remove the "silly" rules. I like this because sonarqube still has a nice way to view history for issues + coverage. There is also akiddo which we can try.
• Enable pmd, spotbugs, or whatever for java to have a consistent set of rules -- i am resistant to arguing over style and feel a strong style cop can be the arbiter

But for this pr, i think you are ok to give it a shot and we'll see what sonarqube says?

[wolpert]

I already have a bunch of stuff for Java, beyond jacoco I have spotless and whatnot. I added jacoco enforcement.... But I'll merge in this pr and I'll consider the options in the morning.

[bernata]

I already have a bunch of stuff for Java, beyond jacoco I have spotless and whatnot. I added jacoco enforcement.... But I'll merge in this pr and I'll consider the options in the morning.

Can you access the sonarqube report. The logs say:

04:02:11.815 INFO  ANALYSIS SUCCESSFUL, you can find the results at: https://sonarcloud.io/dashboard?id=codeheadsystems_passkeys-browser&branch=main&resolved=false
04:02:11.815 INFO  Note that you will be able to access the updated dashboard once the server has processed the submitted analysis report

But i wasn't allowed to access https://sonarcloud.io/dashboard?id=codeheadsystems_passkeys-browser&branch=main&resolved=false

Wondering if its a me thing? @wolpert