Asap 234 new tagged mixed protocol bug - #336
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last changes to the crawler had some flaws around protocol and url encoding. We join the current crawl on the previous crawl based on URL. URLs which are the same other than protocol and url encoding should be treated as identical. They were not and the resulting behavior created additional rows with different crawl statuses. The document import rake task collapses them during import, however, it takes the last crawl status variable presented. Hence we ended up with some existing documents marked as "new".
This PR joins the two crawl csvs on a normalized url column that has been decoded and has the protocol removed. We then drop duplicates for good measure, preferring the first record. I've also updated the tests to include problematic scenarios. Lastly, I replaced the SLC crawl data from 2025-09-25 with a new cut from 2025-10-07. Once this PR is deployed to prod, I'll clean up the documents there.