1337 load documents by encoding variant - #330
Merged
Merged
Conversation
lkacenja
marked this pull request as ready for review
October 2, 2025 16:05
lkacenja
added a commit
that referenced
this pull request
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We changed our url encoding for database storage several times in the past. Some phase of that work created varied partial and full encodings in the database. Our import process matches previous records based on URL. Since we have some dirty data in the column, we should make the match more fuzzy, encoding-wise.
This PR searches for existing documents via a url encoding variant approach. It creates a bunch of encoding variants and then finds documents with an IN operator. It also adds test coverage for a few duplication scenarios.