Hide llm author for inferences without one. - #295
Merged
Conversation
lkacenja
added a commit
that referenced
this pull request
Sep 3, 2025
* Asap 208 feedback UI (#265) * Add feedback item model. * Add feedback controller. * Add static markup for feedback widget. * Functional feedback UI. * Add deletion route and make feedback user-based. * Remove checkboxes. * Use auto timestamps. * Move hidden fields out of additional comments. * Wrap interface in form tag. * Use buttons for feedback. * Add a test for the feedback UI. * Clean up sass. * Specify fallback versioning. * Run accessibility scan on feedback form. * Fix linting issues. * Asap 216 collect more llm information (#286) * Return token usage and model name from document inference. * Set token usage and model name on API calls. * Update schema to incldue token usage and model name. * Get rid of pypdf. * Return commented out portion. * Remove pypdf. * Add model name to inference UIs. * Add llm author to tests. * Remove scratch script. * Fix up linting issues. * Fix tests. * Asap 215 document audit export (#284) * Stashing initial work on background job. * Stash progress on exporting. * Mostly function audit export page. * Clean up and make localstack erros more obvious. Move secret names to config. * Remove secret name constants. * Use actual bucket name. * Move S3 permissions to the correct role. * Allow backend to handle errors. * Refactor and simplify API. * Add swagger UI to the app. * Fix API paths and example. * Handle errors more gracefully. * Use staging bucket name (default). * Improve access and responses as revealed by testing. * Refactor tests for new endpoints. * Fix up linting issues. * Remove future fields from factory. * Fix tests by matching new routes and using required fields. * Add a light test for exports. * Dep: 2025-09-03 (#294) * Bump pg from 1.6.1 to 1.6.2 (#293) Bumps [pg](https://github.com/ged/ruby-pg) from 1.6.1 to 1.6.2. - [Changelog](https://github.com/ged/ruby-pg/blob/master/CHANGELOG.md) - [Commits](ged/ruby-pg@v1.6.1...v1.6.2) --- updated-dependencies: - dependency-name: pg dependency-version: 1.6.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Leo Kacenjar <lkacenja@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump aws-sdk-ses from 1.88.0 to 1.90.0 (#292) Bumps [aws-sdk-ses](https://github.com/aws/aws-sdk-ruby) from 1.88.0 to 1.90.0. - [Release notes](https://github.com/aws/aws-sdk-ruby/releases) - [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-ses/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-ruby/commits) --- updated-dependencies: - dependency-name: aws-sdk-ses dependency-version: 1.90.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Leo Kacenjar <lkacenja@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump aws-sdk-lambda from 1.158.0 to 1.160.0 (#291) * Bump aws-sdk-lambda from 1.158.0 to 1.160.0 Bumps [aws-sdk-lambda](https://github.com/aws/aws-sdk-ruby) from 1.158.0 to 1.160.0. - [Release notes](https://github.com/aws/aws-sdk-ruby/releases) - [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-lambda/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-ruby/commits) --- updated-dependencies: - dependency-name: aws-sdk-lambda dependency-version: 1.160.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Reroll lock file. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Leo Kacenjar <lkacenja@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Hide llm author for inferences without one. (#295) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we already have inferences, we get a blank "Generated by:" message. We should check
inference_model_namebefore displaying the message.This PR gates the "Generated by:" message with a
inference_model_namecheck.