Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Core publishes local Docker ports on IPv4 loopback but generated native mappings use localhost, which may resolve to IPv6. Emit the matching IPv4 loopback address through the existing mapping owner.
👤 Human — what changed & where to look
Risk / rollback: Medium; this changes shared behavior or data interpretation. Revert the focused commit and restore the prior selection. This PR is draft pending qualification.
🤖 Bot — correctness & where to distrust
Decisions & rationale
Fix the native mapping producer instead of changing each consuming module or widening Docker exposure. The loopback address is a runtime-model constant, not a copied service endpoint.
Invariants / assumptions
Preserve owner boundaries, immutable inputs and existing authority/data-integrity checks. Classify this change as a fix at the behavior's owner; no workaround is proposed.
Edge cases
Exercise the focused counterexamples in the added/existing regressions; do not infer compatibility beyond the selected source and tested paths.
Non-obvious mechanism
Align Native and NativeFor mappings and document their emitted addresses; retain container/public mapping and deterministic port behavior.
Not verified / unsure
Network and related resources/configurations tests pass. Current Codefly also builds against the patched Core. Full ordinary Go suite attempted; infrastructure tests require unavailable Nix. No full-suite pass or hosted qualification claimed. Required CI and composed native runtime witness are pending.
Testing / Validation
Network and related resources/configurations tests pass. Current Codefly also builds against the patched Core. Full ordinary Go suite attempted; infrastructure tests require unavailable Nix. No full-suite pass or hosted qualification claimed. Required CI and composed native runtime witness are pending.
Open questions / Next steps
Finish required CI and the reconciled local composition before marking ready or merging. Source commit:
511c9a8dbb6a4100fc53182aadc99af33ecbef01.