Repository navigation
fix(runners): count effective environment before carrier delivery - #867
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native services can receive the same configuration at environment and process scope. Core counted both copies before Go's existing last-key-wins normalization, refusing Product's 134-binding environment as 762462 bytes even though its effective configuration fits the unchanged 524288-byte limit.
This fix at the owning Core boundary normalizes exact keys before native/Nix carrier materialization and counting. It preserves the complete winning variable, including File/Secret metadata, and keeps inline/file-carrier aliases distinct. Kubernetes rendering applies the same rule within its existing public and secret categories after restricted-profile checks, matching its existing map precedence. No operations, configuration values, transport, thresholds or limits are changed.
Behavior is documented in
docs/runnable-binding-delivery.md. The correction is separately frozen at0772bc0d; this branch normally merges current main2e1857f0without changing its version metadata or prior companion work. All seven correction files remain byte-identical to the freeze.Validation on the correction: focused resources/base/services tests PASS, focused race PASS, restricted-secret and object-limit tests PASS, and affected-package vet PASS. A production-only reversal reproduces the native duplicate-size/metadata-transition failures and Kubernetes duplicate-size failure. Tests retain all 134 bindings and cover changed-value precedence, File/Secret metadata, genuine unique oversize refusal, and distinct carrier ambiguity.
No local engine, Nix executable, Kubernetes cluster or Product launch was run. Native agents must consume this Core correction themselves; rebuilding CLI alone does not update their embedded Core. Canonical CI supplies the broader delivery gates. No manual tag or new release programme is part of this fix.