This repository was archived by the owner on Oct 7, 2025. It is now read-only.
Updating cloud front role pr devel 2.x#2593
Closed
matej5 wants to merge 28 commits into
Closed
Conversation
…init-linotp-db-after-upgrade-PR-2.x
…inotp-db-after-upgrade-PR-2.x
…lab-PR-2.x sync-disabled-ldap-users-gitlab systemd timer
…upgrade-PR-2.x r71691-init-linotp-db-after-upgrade
|
| cache_behaviors: [] # A list of cache behaviors same as default_cache_behavior with additional path_pattern var required. | ||
| enabled: true | ||
| purge_existing: true # Set to false to append entries instead of replacing them. | ||
| web_acl: false # Set to true to create Web ACL for WAF. |
Contributor
There was a problem hiding this comment.
please put this line back:)
tymofiisobchenko
suggested changes
Jul 29, 2025
tymofiisobchenko
left a comment
tymofiisobchenko
left a comment
Contributor
There was a problem hiding this comment.
we don't want web_acl created when it's not needed
| cache_behaviors: [] # A list of cache behaviors same as default_cache_behavior with additional path_pattern var required. | ||
| enabled: true | ||
| purge_existing: true # Set to false to append entries instead of replacing them. | ||
| web_acl: false # Set to true to create Web ACL for WAF. |
Contributor
There was a problem hiding this comment.
please put this line back:)
| name: aws/aws_acl | ||
| when: | ||
| - aws_cloudfront_distribution.web_acl | ||
| # - aws_cloudfront_distribution.web_acl |
Contributor
There was a problem hiding this comment.
please put this condition back:)
Other conditions are always true, since the aws_acl role has that defined in defaults/main.yml
So we will always create web_acl if that condition removed, which we DON'T want, some don't need web_acls at all!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.