fix: use temp file for non-seekable zip bodies to reduce memory (fixes #22) - #36
Open
AruneshDwivedi wants to merge 2 commits into
Open
fix: use temp file for non-seekable zip bodies to reduce memory (fixes #22)#36AruneshDwivedi wants to merge 2 commits into
AruneshDwivedi wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #22: Heavy memory usage when extracting large zip files
Previously, when the zip body was not a seekable Reader, the entire archive was
loaded into a bytes.Buffer in memory, which could cause OOM errors for large
archives. This fix streams the body to a temporary file instead, significantly
reducing memory usage.
The temp file is automatically cleaned up via defer. The approach maintains
compatibility with zip.NewReader which requires a ReaderAt, while avoiding
the memory overhead of buffering the entire archive.
Test suite passes with this change.