Skip to content

V10.0.8/service update#30

Merged
gimlichael merged 8 commits into
mainfrom
v10.0.8/service-update
Jun 6, 2026
Merged

V10.0.8/service update#30
gimlichael merged 8 commits into
mainfrom
v10.0.8/service-update

Conversation

@codebelt-aicia

@codebelt-aicia codebelt-aicia Bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

This is a service update that focuses on package dependencies.

Automated changes:

  • Codebelt/Cuemon package versions bumped to latest compatible
  • PackageReleaseNotes.txt updated for v10.0.8
  • CHANGELOG.md entry added for v10.0.8

Note: Third-party packages (Microsoft.Extensions.*, BenchmarkDotNet, etc.) are not auto-updated.
Use Dependabot or manual updates for those.

Generated by codebelt-aicia
Triggered by: yamldotnet @ 10.1.4

@greptile-apps

greptile-apps Bot commented Jun 6, 2026

Copy link
Copy Markdown

Greptile Summary

This is a v10.0.8 service update bumping Codebelt/Cuemon package versions, adding new regression tests for wrapped IServiceProvider scenarios, expanding the CI pipeline with an optional macOS test matrix and a centralized quality-gate job, and introducing AGENTS.md with developer/agent guidance.

  • Package bumps: Codebelt.Extensions., Cuemon., and Microsoft.NET.Test.Sdk incremented to latest compatible versions in Directory.Packages.props.
  • New tests: ServiceProviderExtensionsTest and two new ProblemDetailsFactoryTest cases verify that GetServiceDescriptors() and UseFaultDescriptorExceptionHandler work correctly when RequestServices is wrapped by either DelegatingServiceProvider or a name-matched InjectApiVersion stub.
  • CI workflow: Adds an opt-in macOS test matrix (macos-26/macos-26-intel), a test_qualitygate aggregation job that gates downstream analysis and deploy jobs, and threads sonarcloud/codecov/codeql/deploy through the new gate.

Confidence Score: 5/5

Safe to merge — all changes are additive (package bumps, new tests, CI expansion, docs) with no modifications to production source code.

The diff touches only packages, tests, CI configuration, and documentation. No production logic is changed. The new tests exercise wrapper scenarios that were previously untested. The quality-gate workflow logic correctly handles skipped and failed job states.

No files require special attention. The ProblemDetailsFactoryTest.cs cross-file stub reference is a minor organisation point, not a functional concern.

Important Files Changed

Filename Overview
.github/workflows/ci-pipeline.yml Adds optional macOS test matrix, a test_qualitygate aggregation job, and threads sonarcloud/codecov/codeql/deploy through the quality gate; logic looks correct.
Directory.Packages.props Routine Codebelt/Cuemon/Microsoft.NET.Test.Sdk package version bumps for v10.0.8.
test/Codebelt.Extensions.Asp.Versioning.Tests/Assets/DelegatingServiceProvider.cs New test helper wrapping IServiceProvider via delegation; placed correctly in Assets/.
test/Codebelt.Extensions.Asp.Versioning.Tests/ProblemDetailsFactoryTest.cs Two new integration tests added verifying FaultDescriptor exception handler works when RequestServices is wrapped; references InjectApiVersion stub defined in a different test file.
test/Codebelt.Extensions.Asp.Versioning.Tests/ServiceProviderExtensionsTest.cs New unit tests for GetServiceDescriptors(); includes InjectApiVersion test stub at the bottom of the file in a separate namespace.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    init --> build
    init --> pack
    build --> test_linux
    build --> test_windows
    build --> test_mac
    test_linux --> test_qualitygate
    test_windows --> test_qualitygate
    test_mac --> test_qualitygate
    build --> sonarcloud
    test_qualitygate --> sonarcloud
    build --> codecov
    test_qualitygate --> codecov
    build --> codeql
    test_qualitygate --> codeql
    build --> deploy
    pack --> deploy
    test_qualitygate --> deploy
    sonarcloud --> deploy
    codecov --> deploy
    codeql --> deploy
Loading
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
test/Codebelt.Extensions.Asp.Versioning.Tests/ProblemDetailsFactoryTest.cs:45
**Implicit dependency on a test stub defined in another file**

`ProblemDetailsFactoryTest.cs` references `global::Asp.Versioning.Builder.EndpointBuilderFinalizer.InjectApiVersion`, but this type is not the real Asp.Versioning type — it is a test-local stub defined at the bottom of `ServiceProviderExtensionsTest.cs` (lines 52–71). A reader encountering this reference in `ProblemDetailsFactoryTest.cs` has no indication it is a test double rather than the real package type. This is inconsistent with the project's established pattern where test infrastructure lives in the `Assets/` folder (as `DelegatingServiceProvider` does). Moving the stub to `Assets/` (e.g., `Assets/InjectApiVersionStub.cs`) would make the dependency explicit and the intent clear to future maintainers.

Reviews (3): Last reviewed commit: "💬 add .bot workspace documentation for ..." | Re-trigger Greptile

Comment thread Directory.Packages.props
<PackageVersion Include="Asp.Versioning.Mvc" Version="10.0.0" />
<PackageVersion Include="Asp.Versioning.Mvc.ApiExplorer" Version="10.0.0" />
</ItemGroup>
</Project>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Missing trailing newline

The file ends without a newline character. This shows up as \ No newline at end of file in the diff and can cause noise in future diffs. Adding a single newline after the closing </Project> tag would resolve it.

Prompt To Fix With AI
This is a comment left during a code review.
Path: Directory.Packages.props
Line: 33

Comment:
**Missing trailing newline**

The file ends without a newline character. This shows up as `\ No newline at end of file` in the diff and can cause noise in future diffs. Adding a single newline after the closing `</Project>` tag would resolve it.

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@codecov

codecov Bot commented Jun 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (23c08f5) to head (e123018).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           97        97           
  Branches         9         9           
=========================================
  Hits            97        97           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

aicia-bot and others added 7 commits June 6, 2026 15:33
Update shared package version baseline for improved test framework compatibility and bug fixes.
Add ServiceProviderExtensionsTest with unit tests for GetServiceDescriptors() compatibility with wrapped providers (AspVersioning.InjectApiVersion and DelegatingServiceProvider). Expand ProblemDetailsFactoryTest with integration tests validating exception handler behavior when RequestServices is wrapped. Include DelegatingServiceProvider helper class for test infrastructure.
Extend test writing guidelines with explicit prohibition against using ExcludeFromCodeCoverage attribute on any code path. Provide rationale and alternative approaches for handling untestable code patterns through refactoring and test doubles.
Add workflow_dispatch parameter to enable optional macOS test runs (X64 and ARM64 architectures). Introduce test_qualitygate job to consolidate and validate all test results before downstream jobs, ensuring deployment only proceeds when required tests pass.
Add .bot/ folder to gitignore to keep local-only AI agent ideation, PRDs, and agentic loop state out of version control, while preserving .bot/README.md as a guide.
Establish official agent instructions documenting project overview, coding standards, project structure, test conventions, build and CI configuration, .bot/ folder guidance, and git operation safeguards. Provides authoritative guidance for AI agents working in this repository.
@gimlichael gimlichael merged commit f47210d into main Jun 6, 2026
24 checks passed
@gimlichael gimlichael deleted the v10.0.8/service-update branch June 6, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants