Skip to content

ci: add shellcheck for shell scripts#25

Merged
till merged 3 commits into
mainfrom
feature/shellcheck
Jun 11, 2026
Merged

ci: add shellcheck for shell scripts#25
till merged 3 commits into
mainfrom
feature/shellcheck

Conversation

@mroderick

@mroderick mroderick commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Adds shellcheck to CI workflow with warning severity threshold to catch shell script issues before merge.

Closes #13

This is useful, because the Heroku deployment PR #10 contains a shell script: https://github.com/codebar/auth/pull/10/changes#diff-b6bbfb89e039f6bef870b653af2a2b55bf7bef1b3e3be3f2fa102224b1d59b46

Adds shellcheck to CI workflow with warning severity threshold
to catch shell script issues before merge.

Closes #13
Comment thread .github/workflows/ci.yml Fixed
Comment thread .github/workflows/ci.yml Fixed
The previous SHA (00b27aa7cb85167568d10283c1dce7810666b51d) did not
resolve to a valid version of ludeeus/action-shellcheck. Replace
with the correct v2.0.0 commit SHA (00cae500b08a931fb5698e11e79bfbd38e612a38).
Comment thread .github/workflows/ci.yml Fixed
zizmor's hash-pin verification requires the comment to match the
exact tag name in the repository. The tag is , not .

Fixes security scanning alert in PR #25.
@mroderick mroderick marked this pull request as ready for review June 10, 2026 17:00
@mroderick mroderick requested a review from till June 10, 2026 17:00
@till till merged commit 7428b7b into main Jun 11, 2026
6 checks passed
@till till deleted the feature/shellcheck branch June 11, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shellcheck

3 participants