Repository navigation
test(telegram): wait for events instead of racing them - #53
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two tests in
internal/telegramfailed now and then, also in CI. Both were test bugs; the approver code is unchanged.TestCoreRedeliveredTapKeepsResult: the old broker's lastgetUpdatescall could still reach the shared fake server after the broker stopped, and confirm the tap the test had just sent again, so the new broker never got it. Each broker now has its own fake server, closed when it stops.TestCoreExpiredTap: the approver answers a tap and then reports it; the test counted reports right after the answer. It now waits for the report.TestCoreDoubleTap,TestCoreEarlyTap,TestCoreApproveOnce,TestCoreWrongMessage,TestTapDataCannotForgeAnAnchor.Tests
go test -race -count=200 -cpu 1,2,4 -run TestCore ./internal/telegram/passes with Go 1.27 and Go 1.26. Before the fix, the first test failed 26 to 29 of 120 runs.Review
One round with the security-reviewer agent: "ready to commit". A restart can lose only taps the old broker had already handled; no test got weaker.
Closes #51