Repository navigation
fix(approval): a refused notice is a limit, and does not use up max_per_day - #52
Merged
Merged
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A "never ask" use needs a notice when its rule has
notify = true. Until now, when the Telegram approver refused a notice because of its own limit (20 per minute for all clients), the core treated it as an approver failure: causeerror, and the use still counted formax_per_day. So other clients' notices could use up a rule's only use of the night.approval.ErrLimit. An approver returns it (wrapped) when its own limit refuses a notice before sending anything;telegram.ErrNoticeLimitwraps it.limitand takes the use back, only for the day it was counted.Notifyfailure still denies and still counts, because the core cannot know whether the notice went out.Docs
DESIGN.md sections 7, 8 and 12; THREAT-MODEL.md T9 and T21.
Review
One round with the security-reviewer agent: no findings. Uses at the same time, midnight and a clock set back cannot give more than
max_per_day; the reviewer's four attack tests are kept.Closes #47