Repository navigation
docs: say the secret goes to the command, not to the agent - #167
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #159
Say who gets what: the agent asks, a person approves on the phone, the value goes only into the environment of one command, and nodkey never puts it into the agent's chat. The limit is next to that claim: the agent writes the command, so a bad command can print or send the value.
Progress
AGENTS.mdand.claude/agents/security-reviewer.mddescribe nodkey as: access after approval, nodkey never shows the secret to the agentDESIGN.mdL5–9 and goal 1 (L34) reworded;SECURITY.mdscope line tooGH_TOKENline say who sees whatChoices
docs/diagrams/src/who-sees-the-secret.py), rendered to SVG and PNG with the workspace'sdrawtool. The README links the SVG. Schemdraw was the lean choice: one short Python file, no new tool in this repo, and no build step in CI./proc/PID/environwhile the command runs. README, DESIGN.md, AGENTS.md and the reviewer brief now say this next to the claim, and THREAT-MODEL.md section 5 item 1 no longer says root is needed for it.