[pull] main from tinacms:main - #334
Merged
Merged
Conversation
## What was wrong Any environment that sets `CI` (GitHub Actions does by default) got the end-of-build summary as a raw JSON object instead of the boxed summary a local run prints. The logger had a branch that switched to JSON when `CI` was set. It was added in 2023 (653522a) with no recorded reason, and nothing in the repo reads that JSON. ## Change - Remove the `CI` branch in `packages/@tinacms/cli/src/logger/index.ts`. The summary now prints the same way everywhere. - Add `packages/@tinacms/cli/src/logger/index.test.ts`. It sets `CI=true` and checks the output is the box, not JSON. The test fails on `main` and passes here. - Changeset: patch for `@tinacms/cli`. `tinacms dev` uses the same logger, so its summary changes the same way. ## Before and after Both captured with `CI=true` and the same summary payload. **Before** ``` { "heading": "Tina build complete", "items": [ { "emoji": "🦙", "heading": "Tina Config", "subItems": [ { "key": "API url", "value": "https://content.tinajs.io/2.4/content/<client-id>/github/redesign" } ] }, ... ] } ``` **After** ``` │ ○ Tina build complete ───────────────────────────────────────────────╮ │ │ │ 🦙 Tina Config │ │ API url: https://content.tinajs.io/2.4/content/... │ │ │ │ 🤖 Auto-generated files │ │ GraphQL Client: tina/__generated__/client.ts │ │ Typescript Types: tina/__generated__/types.ts │ │ Static HTML file: public/admin/index.html │ │ │ ├─────────────────────────────────────────────────────────────────────╯ ``` 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01LssiV88a13d9btvmuDGDbK Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )