ci(review): add review-claim label gate and modernize action pins - #1249
Merged
Conversation
Three PR labels (will-review, in-review, stale-review) drive review claims: the "Review claim gate" job fails while a claim label is present, labeling auto-requests the labeler as reviewer and clears stale-review, the claim is released only when the claimer submits an approve or request-changes review, and a 6-hourly sweep moves 3+ day old claims to stale-review. AGENTS.md documents the labels and the never-merge-a-claimed-PR rule.
Two competing actions/checkout pins and two competing actions/setup-node pins collapse onto v7.0.1 and v7.0.0; upload-artifact moves to v7.0.1 and download-artifact to v8.0.1 off the retiring v4 line, and oven-sh/setup-bun lands on v2.2.0. Only uses: lines change and every pin keeps the repo's full-SHA plus version-comment style.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Installs the review-claim label system and unifies the shared GitHub Action pins on their current majors.
The three labels
will-reviewfbca04in-review1d76dbstale-reviewd93f0bThe labels already exist on the repository; this PR ships the automation and the documentation.
The merge gate
Review claim gatefails whilewill-revieworin-reviewis present on the PR, and passes otherwise. It runs onpull_request_targetfor open / reopen / synchronize / ready_for_review / label / unlabel, so the status refreshes the moment a claim is applied or released. The job name is stable so it can be wired up as a required branch-protection context; that wiring is intentionally not part of this PR.The automation jobs
Review claim gatepull_request_targetRegister claimer as reviewerstale-review. Skips bots and self-review by the PR author.Release claim on claimer reviewpull_request_reviewsubmittedSweep stale review claims23 */6 * * *+ manualstale-review.Claim ownership is resolved from the issue timeline (
labeledevents), so a claim can only be released by its own claimer.Version bumps
Two competing
actions/checkoutpins and two competingactions/setup-nodepins are collapsed onto one verified SHA each; the artifact actions leave the retiring v4 line. Every pin keeps the repository's full-commit-SHA style with a trailing version comment.actions/checkoutdf4cb1c0(15x) +3d3c42e5(3x)3d3c42e5aac5ba805825da76410c181273ba90b1actions/setup-node48b55a01(15x) +82076278(3x)820762786026740c76f36085b0efc47a31fe5020actions/upload-artifactea165f8d(v4.6.2)043fb46d1a93c77aae656e7c1c64a875d1fc6a0aactions/download-artifactd3f86a10(v4.3.0)3e5f45b2cfb9172054b4087a40e8e0b5a5461e7coven-sh/setup-bun4bc047ad(v2.0.1)0c5077e51419868618aeaa5fe8019c62421857d6actions/github-script(new file)3a2844b7e9c422d3c10d287c895573f7108da1b3Only
uses:lines change in the bump commit — no runner labels, no unrelated actions, no reformatting.Verification
actionlintv1.7.10: exit 0, zero findings.node scripts/check-pr-changelog.mjs:PASS - changes.md coverage complete (4 production path(s) covered); no runtime source changes detected. The four upstream-owned workflows are covered in.github/changes.mdwith all four canonical sections, so nono-changeloglabel is required.main;review-claims.ymlitself writes a summary in every job (baseline 5/12 -> 6/13).Summary by cubic
Adds a review-claim label system that blocks merges while a PR is claimed, and unifies the shared GitHub Action pins on current majors.
will-reviewandin-reviewfail theReview claim gatejob; applying one requests the labeler as reviewer and clearsstale-review.stale-review, which signals the PR needs a new reviewer.pull_request_targetso the status refreshes on label changes; branch protection must still be wired to the job separately.actions/checkoutv7.0.1,actions/setup-nodev7.0.0,actions/upload-artifactv7.0.1,actions/download-artifactv8.0.1, andoven-sh/setup-bunv2.2.0 as single SHAs, collapsing the two competing checkout and setup-node pins.uses:lines change across the modified workflows.Written for commit 65a1ed3. Summary will update on new commits.