Skip to content

test(pty): make native wait cleanup cancellation deterministic #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
code-yeongyu merged 1 commit into from
Aug 30, 2026
Merged

test(pty): make native wait cleanup cancellation deterministic #1221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/pty/test/fixtures/native-wait-threadpool-starvation.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,14 +79,16 @@ try {
} finally {
for (const session of sessions) {
try {
session.kill("SIGKILL");
// Mark cancellation before signalling so a fast exit cannot beat the
// waiter's cancellation flag observation.
session.kill();
} catch {
// The child may have exited while another session was being stopped.
}
try {
session.kill();
session.kill("SIGKILL");
} catch {
// Mark cancellation even if the explicit SIGKILL already won the race.
// The cancellation-marking kill already stopped the process.
}
}
const exits = await deadline(Promise.all(waits), 5_000, "PTY_CLEANUP_TIMEOUT");
Expand Down
Loading