test(auth): add EnsureFreshToken 30-second expiry buffer tests#5
Open
chrisipanaque wants to merge 1 commit into
Open
test(auth): add EnsureFreshToken 30-second expiry buffer tests#5chrisipanaque wants to merge 1 commit into
chrisipanaque wants to merge 1 commit into
Conversation
The proactive refresh in EnsureFreshToken has a 30-second safety buffer that triggers a token refresh before the access token actually expires. This avoids the latency penalty of a 401+retry cycle when a request lands just after the server-side expiry. Cover four behaviours at the buffer boundary: no expiry, outside the buffer (45s remaining), inside the buffer (15s remaining), and already expired. Each direction of buffer-value change is caught by at least one case, protecting against accidental regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds test coverage for the 30-second proactive refresh buffer in
EnsureFreshToken(internal/auth/refresh.go:65). The buffer ensuresa token is refreshed before it expires, avoiding a 401+retry penalty on
every request in the ~30s window before actual expiry.
What was verified
Guard
If the buffer value in
cfg.ExpiresAt - <N> > nowis changed, at leastone case flips and fails the test:
now+45falls inside the buffer → case 2 failsnow+15falls outside the buffer → case 3 failsVerification