fix(fundingrequests): run journal/publisher search on Enter in DOI type-change forms - #276
Open
fjen wants to merge 4 commits into
Open
fix(fundingrequests): run journal/publisher search on Enter in DOI type-change forms#276fjen wants to merge 4 commits into
fjen wants to merge 4 commits into
Conversation
SvenMarcus
requested changes
Sep 1, 2026
fjen
force-pushed
the
fix/doi-import-search-submission
branch
2 times, most recently
from
September 2, 2026 09:24
9c108c8 to
ece7d97
Compare
…pe-change forms Pressing Enter in the journal or publisher search field submitted the enclosing form instead of triggering the HTMX search. For the article form this posted doi_preview_apply_type_change, which could apply the type change with a stale or unselected journal. Form is now moved to include just the selected search result.
…odal Publisher radios in the DOI modal posted clear_publisher_error and targeted #publisher-error, which only exists in the wizard step, so htmx aborted every selection with a targetError. Now mirroring doi_journal_row.html on the journal side.
The identifying column is now a <label for> of each row's radio, so clicking a title/name selects the row and screen readers announce the entity instead of an unnamed control.
fjen
force-pushed
the
fix/doi-import-search-submission
branch
from
September 2, 2026 09:57
ece7d97 to
d4bdabc
Compare
Collaborator
Author
|
"Small" overhaul of the whole template mess around journal/publisher. Now the result rows dont send htmx requests to clear some error div. That way we also got rid of DOI specitic row templates. |
…r-row endpoints Selecting a journal/publisher result no longer posts from the row. The error <ul> itself watches the radios (hx-trigger) and swaps itself empty against one shared empty-response endpoint, so journal_row/publisher_row are inert and shared with the DOI modal. Removes the row_template override mechanism, doi_*_row.html and the clear_journal_error/clear_publisher_error views, partials and URLs. Side effect: no htmx targetError noise when selecting without an active error, in either the wizard or the DOI modal.
fjen
force-pushed
the
fix/doi-import-search-submission
branch
from
September 2, 2026 10:00
d4bdabc to
057ebee
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing Enter in the journal or publisher search field submitted the enclosing form instead of triggering the HTMX search. For the article form this posted doi_preview_apply_type_change, which could apply the type change with a stale or unselected journal.
Change:
Dialog in focus:
