Skip to content

Ltminhthu/profit and lost #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
craftznake wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Ltminhthu/profit and lost #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b494034
fix: not render PnL if value is 0
craftznake Aug 18, 2024
c7d98fe
chore: Merge branch 'dev' into check_old_pnl-1
craftznake Aug 18, 2024
5c36208
chore: revise logic to render pnl
craftznake Sep 11, 2024
c02fbe6
chore: fix lint
craftznake Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 38 additions & 24 deletions apps/wallet/src/components/TotalPnL.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,37 +6,51 @@ interface Props {
value: number;
percentage: number;
isDarkTheme: boolean;
numDigit: number;
}

const TotalPnL: FC<Props> = ({ value, percentage, isDarkTheme = false }) => {
const TotalPnL: FC<Props> = ({
value,
percentage,
isDarkTheme = false,
numDigit = 2,
}) => {
if (numDigit <= 0) {
numDigit = 2;
}
const baseDigit = 10 ** numDigit;
value = Math.round(value * baseDigit) / baseDigit;
percentage = Math.round(percentage * baseDigit) / baseDigit;
const isLost = value < 0;
const isProfit = value > 0;

return (
<View style={styles.container}>
<Text
style={[
styles.pnlTextBase,
styles.pnlValueBase,
isDarkTheme ? styles.darkThemePnLText : styles.lightThemePnLText,
]}
>
{isLost ? `≈ -$${-value}` : isProfit ? `≈ +$${value}` : null}
</Text>
<View
style={[
styles.percentageContainerBase,
isLost
? styles.LostPercentageContainer
: styles.ProfitPercentageContainer,
]}
>
<Text style={[styles.pnlTextBase]}>
{isLost ? `${percentage}%` : isProfit ? `+${percentage}%` : null}
if (percentage !== 0) {
return (
<View style={styles.container}>
<Text
style={[
styles.pnlTextBase,
styles.pnlValueBase,
isDarkTheme ? styles.darkThemePnLText : styles.lightThemePnLText,
]}
>
{isLost ? `≈ -$${-value}` : isProfit ? `≈ +$${value}` : null}
</Text>
<View
style={[
styles.percentageContainerBase,
isLost
? styles.LostPercentageContainer
: styles.ProfitPercentageContainer,
]}
>
<Text style={[styles.pnlTextBase]}>
{isLost ? `${percentage}%` : isProfit ? `+${percentage}%` : null}
</Text>
</View>
</View>
</View>
);
);
}
};

export default TotalPnL;
Expand Down
5 changes: 3 additions & 2 deletions apps/wallet/src/features/Home/TokenValue.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,10 @@ const TokenValue: FC<Props> = ({ value }) => {
</Hoverable>
</View>
<TotalPnL
value={Math.round(pnl * 100) / 100}
percentage={Math.round(pnlRates * 100) / 100}
value={pnl}
percentage={pnlRates}
isDarkTheme={true}
numDigit={2}
/>
</View>
</View>
Expand Down
7 changes: 4 additions & 3 deletions apps/wallet/src/features/Widget/BuiltInNetwork/WalletCard/Balance.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,10 @@ export const WalletBalance: FC<Props> = ({
</View>
<View style={styles.pnLContainer}>
<TotalPnL
value={Math.round(pnl * 100) / 100}
percentage={Math.round(pnlRates * 100) / 100}
isDarkTheme={false}
value={pnl}
percentage={pnlRates}
isDarkTheme={true}
numDigit={4}
/>
</View>
</View>
Expand Down