feat: improve cross resolving context - #2
Open
FME849 wants to merge 2 commits into
Open
Conversation
FME849
commented
Jun 13, 2024
FME849
commented
Collaborator
- Including the origin sender in the payload
- Enable manually handle cross-resolving context
tanlethanh
reviewed
Jun 14, 2024
| requestId: string; | ||
| resolve: (value: unknown) => void; | ||
| reject: (error: Error | string) => void; | ||
| resolveCallback?: Middleware; |
Member
There was a problem hiding this comment.
please add a document for this param
tanlethanh
reviewed
Jun 14, 2024
| respond({ message: 'ok' }); | ||
| } else { | ||
| await resolveCallback(request, respond, resolve); | ||
| } |
Member
There was a problem hiding this comment.
you should add an unit test for this one
Member
There was a problem hiding this comment.
also, how about auto repond respond({ message: 'ok' }); after await resolveCallback(request, respond, resolve);. That means the resolveCallback is used to proxy the request to check for resolving only, don't need to care about respond to resolver. And the callback middleware itself only throws Error if the resolving request is not accepted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.