build: consume cocoon's exported json namespace declarations - #24
Merged
Conversation
cocoon now exports JSONNamespace() on the cloudimg and cni backends (cocoonstack/cocoon#165), so drop the two hand-copied namespace declarations and the drift-guard test that pinned them — the layout can no longer diverge from cocoon's by construction.
CMGS
added a commit
that referenced
this pull request
Jul 23, 2026
cocoon now exports JSONNamespace() on the cloudimg and cni backends (cocoonstack/cocoon#165), so drop the two hand-copied namespace declarations and the drift-guard test that pinned them — the layout can no longer diverge from cocoon's by construction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to cocoonstack/cocoon#165, which moved the json meta namespace declarations into the backend packages that own them.
Bumps cocoon to
v0.5.6-0.20260723104456-be85485(the merge commit) and replaces the two hand-copiedmetajson.Namespaceblocks with the newly-exported methods:home.OpenStore→cloudimg.NewConfig(...).JSONNamespace()cni.NewConfig(conf).JSONNamespace()Also drops
TestCloudimgNamespace: it existed only to pin the hand-copy against cocoon's layout, and the layout can no longer diverge by construction now that both binaries obtain it from the same source.TestOpenStoreEmptystill exercises the fullOpenStorepath end to end.Net -78 lines. Gates:
go builddarwin + linux,go test(darwin),golangci-lintclean on the changed files; runtimeimage lssmoke-tested against a fresh state dir.