Skip to content

fix(image): retry oras-go pull on transient ghcr stream drops #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CMGS merged 1 commit into from
Jul 2, 2026
Merged

fix(image): retry oras-go pull on transient ghcr stream drops #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions cmd/image/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,30 @@ func (h *Handler) Pull(cmd *cobra.Command, args []string) error {
// blob straight into the store. Credentials still come from the user's docker config (public
// images pull anonymously), so no external oras binary is needed.
logger.Debugf(ctx, "pulling OCI artifact %s via oras-go", ref)
rc, err := pullOCILayer(ctx, ref)
if err != nil {
return err
// retry transient registry stream drops: ghcr resets the HTTP/2 stream on multi-GB blobs with
// PROTOCOL_ERROR mid-copy. A fresh fetch (from the start — mid-stream can't resume) usually wins.
var perr error
for attempt := 1; attempt <= 3; attempt++ {
rc, ferr := pullOCILayer(ctx, ref)
if ferr != nil {
perr = ferr
} else {
perr = s.ImportFromReader(ctx, ref, progress.Nop, rc)
_ = rc.Close()
}
if perr == nil {
return nil
}
logger.Warnf(ctx, "oras pull attempt %d/3 failed: %v", attempt, perr)
if attempt < 3 {
select {
case <-ctx.Done():
return ctx.Err()
case <-time.After(time.Duration(attempt) * 10 * time.Second):
}
}
}
defer func() { _ = rc.Close() }()
return s.ImportFromReader(ctx, ref, progress.Nop, rc)
return fmt.Errorf("pull %s after 3 attempts: %w", ref, perr)
}

// List renders stored images as a table (NAME TYPE SIZE DIGEST CREATED), or JSON with -o json.
Expand Down
Loading