fix: validate CSV columns when checking node drain status#1153
Open
zhengcharon wants to merge 2 commits into
Open
fix: validate CSV columns when checking node drain status#1153zhengcharon wants to merge 2 commits into
zhengcharon wants to merge 2 commits into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The node drain status checker relies on CSV column names from the CockroachDB CLI output.
Previously, missing columns could result in incorrect data access because absent columns defaulted to index 0 in the column map.
This change makes the parsing logic more robust.
Related to #1152