Bump coverlet.collector from 6.0.4 to 10.0.1

.github/workflows/ci.yml

@@ -17,7 +17,7 @@ jobs:
   build-and-test:
     name: ${{ matrix.os }}
     runs-on: ${{ matrix.os }}
-    timeout-minutes: 10
+    timeout-minutes: 15
     strategy:
       fail-fast: false
       matrix:

test/Pants.Tests/Cloud/PantsCloudCrashRecoveryTests.cs

@@ -331,7 +331,8 @@ static async Task WaitForChildReadinessAsync(Process child, string databasePath)
         var readyPath = Path.Combine(databasePath, ReadyFileName);
         while (!File.Exists(readyPath))
         {
-            if (child.HasExited)
+            // The child can publish readiness and exit between these two observations.
+            if (child.HasExited && !File.Exists(readyPath))
             {
                 throw new XunitException(
                     $"Crash child exited with code {child.ExitCode} before readiness.");

test/Pants.Tests/Observability/PantsWalDurabilityMetricsTests.cs

@@ -290,10 +290,8 @@ public async Task ShouldMeasureAppendAndFsyncAtSeparatePhysicalBoundaries()
 
         var metrics = await database.Diagnostics.GetRuntimeMetricsAsync();
         Assert.True(metrics.WalAppendNanosecondsTotal >= 50_000_000);
-        Assert.True(
-            metrics.WalFsyncNanosecondsTotal < metrics.WalAppendNanosecondsTotal,
-            $"Expected fsync {metrics.WalFsyncNanosecondsTotal} ns to exclude " +
-            $"the delayed append {metrics.WalAppendNanosecondsTotal} ns.");
+        Assert.Equal(1, metrics.WalFsyncCount);
+        Assert.InRange(metrics.WalFsyncNanosecondsTotal, 1, failpoints.FsyncWindowNanoseconds);
     }
 
     static async ValueTask CommitAsync(

test/Pants.Tests/Observability/WalAppendDelayFailpointHandler.cs

@@ -1,12 +1,27 @@
+using System.Diagnostics;
+
 namespace Cntryl.Pants.Observability;
 
 sealed class WalAppendDelayFailpointHandler(TimeSpan delay) : IFailpointHandler
 {
+    long _flushStarted;
+
+    public long FsyncWindowNanoseconds { get; private set; }
+
     public void Hit(Failpoint failpoint)
     {
         if (failpoint == Failpoint.MidWalAppend)
         {
             Thread.Sleep(delay);
         }
+
+        if (failpoint == Failpoint.BeforeWalFlush)
+        {
+            _flushStarted = Stopwatch.GetTimestamp();
+        }
+        else if (failpoint == Failpoint.AfterWalFlush)
+        {
+            FsyncWindowNanoseconds = checked(Stopwatch.GetElapsedTime(_flushStarted).Ticks * 100);
+        }
     }
 }

test/Pants.Tests/Runtime/PantsBackgroundFlushPipelineTests.cs

@@ -2623,7 +2623,7 @@ await CommitAsync(
                     {
                         Assert.True(await database.Maintenance.WaitForWriteStallClearAsync(
                             family,
-                            AssertionTimeout));
+                            BackgroundWorkTimeout));
                     }
                 }
             }
@@ -2651,7 +2651,7 @@ async Task ReadLayoutAsync()
         // legitimately take longer than five seconds while eight 132 KiB writes are flushed
         // alongside repeated manifest reads.
         await Task.WhenAll(work).WaitAsync(BackgroundWorkTimeout);
-        await database.Maintenance.FlushAsync(family).AsTask().WaitAsync(AssertionTimeout);
+        await database.Maintenance.FlushAsync(family).AsTask().WaitAsync(BackgroundWorkTimeout);
 
         var layout = await database.Diagnostics.GetStorageLayoutAsync();
         var names = layout.Levels.SelectMany(static level => level.Files)

test/Pants.Tests/Storage/PantsDiskResidentDifferentialTests.cs

@@ -312,7 +312,8 @@ static async Task WaitForCrashChildAsync(Process child, string path)
         var readyPath = Path.Combine(path, CrashReadyFileName);
         while (!File.Exists(readyPath))
         {
-            if (child.HasExited)
+            // The child can publish readiness and exit between these two observations.
+            if (child.HasExited && !File.Exists(readyPath))
             {
                 throw new XunitException(
                     $"Differential crash child exited with {child.ExitCode} before readiness.");

test/Pants.Tests/Transactions/PantsCommitCoalescingCrashRecoveryTests.cs

@@ -366,7 +366,8 @@ static async Task WaitForChildReadinessAsync(Process child, string databasePath)
         {
             while (!File.Exists(readyPath))
             {
-                if (child.HasExited)
+                // The child can publish readiness and exit between these two observations.
+                if (child.HasExited && !File.Exists(readyPath))
                 {
                     throw new XunitException(
                         $"Coalesced-commit crash child exited with code {child.ExitCode} " +

test/Pants.Tests/Transactions/Spill/PantsTransactionSpillCrashRecoveryTests.cs

@@ -177,7 +177,8 @@ static async Task WaitForChildReadinessAsync(Process child, string databasePath)
         {
             while (!File.Exists(readyPath))
             {
-                if (child.HasExited)
+                // The child can publish readiness and exit between these two observations.
+                if (child.HasExited && !File.Exists(readyPath))
                 {
                     throw new XunitException(
                         $"Transaction spill crash child exited with code {child.ExitCode} before readiness.");