feat: configure storage writer lease TTL - #235
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FITZ_STORAGE_LEASE_TTL_SECSwith the existing 30-second default and safety floorttl / 3Why
The Puma foundation needs to run Fitz with a 59-second writer-lease TTL, reducing steady-state S3 lease coordination while retaining immediate takeover after a successful graceful release.
Linked issues
No linked issue: this is a focused runtime configuration extension requested by the platform owner.
Acceptance audit
BootConfigparsesFITZ_STORAGE_LEASE_TTL_SECSandbuild_midge_open_optionspasses the resulting duration toOpenOptionsBuilder::lease_ttl.BootConfig::default->StorageConfig::validate->build_midge_open_options.StorageConfig::validate.Verification
cargo fmt --all -- --checkcargo test --locked --workspacecargo clippy --locked --workspace --all-targets --all-features -- -D warnings -D clippy::pedanticcntryl-tools validate-docs --config .cntryl/repository.tomlcntryl-tools validate-benchmarks --config .cntryl/repository.tomlcntryl-tools check-module-sizes --config .cntryl/repository.tomlgit diff --checkAI assistance disclosure
OpenAI Codex assisted with tracing the pinned Midge lease lifecycle, implementing the configuration plumbing and tests, updating documentation, and running validation. The complete diff and the upstream acquisition, renewal, fencing, and release paths were reviewed before submission.