Skip to content

fix(bench): respect Notice delivery capacity #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smiggleworth merged 1 commit into from
Sep 2, 2026
Merged

fix(bench): respect Notice delivery capacity #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions benches/tier2_subsystem_notice.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,11 @@ const EXACT_ROUTE_16_PUBLISH_REPEAT_COUNT: u64 = 262_144;
const EXACT_ROUTE_64_PUBLISH_REPEAT_COUNT: u64 = 131_072;
const DOUBLE_STAR_16_PUBLISH_REPEAT_COUNT: u64 = 131_072;
const DOUBLE_STAR_64_PUBLISH_REPEAT_COUNT: u64 = 131_072;
const PUBLISH_CHUNK_SIZE: u64 = 512;
// Keep each measured batch within the production per-family delivery lane's
// capacity so this row measures completed fanout rather than intentional
// fire-and-forget drops under saturation.
const PUBLISH_CHUNK_SIZE: u64 = 64;
const DELIVERY_DRAIN_TIMEOUT: Duration = Duration::from_secs(5);

struct NoticePublishCase {
sink: Arc<NoticeDomainSink>,
Expand All @@ -48,7 +52,7 @@ impl NoticePublishCase {
let delivery_count = wait_for_counting_sinks_each_count(
&self.subscriber_sinks,
expected_per_subscriber,
Duration::from_secs(1),
DELIVERY_DRAIN_TIMEOUT,
);
assert_eq!(
delivery_count,
Expand Down