UI polish, Askr reconciliation, and test-suite audit - #211
Open
smiggleworth wants to merge 2 commits into
Open
Conversation
UI: - Fix Sessions page to use the shared DomainSummaryStrip component instead of a bespoke stat layout, matching every other domain page. - Fix QueueDeadLetterDialog to stop overriding askr's themed dialog overlay (was rendering a near-opaque, unblurred scrim instead of the shipped default) on the confirm dialog for an irreversible purge action. - Remove ~290 lines of dead CSS left over from a prior dashboard redesign. - Fix six layout regressions from the askr 0.2.3 Block/Container fix (flex-direction base default: column -> row): DomainSummaryStrip, DomainDataSection, the app shell Container, DomainPageFrame's Main and inner wrapper, and PageHeader, all of which relied on the old implicit default and silently broke when it was corrected upstream. Worked around PageHeader's internal page-header-copy Block (no prop escape hatch) with a scoped, documented CSS override pending an upstream fix. - Fix asymmetric divider inset on the route-family picker list (inset-inline: 1rem 0 -> 1rem), which ran flush to the right edge of the rounded container while stopping short on the left. - Bump @askrjs/askr, @askrjs/themes, @askrjs/ui, @askrjs/cli per `askr update`. Filed upstream against askrjs/askr-themes, askrjs/askr-ui, and askrjs/askr-cli for the framework-level gaps found along the way (Block's non-standard flex-direction default, PageHeader's unreachable inner Block, missing MetaStrip/CopyButton primitives, standalone accessible list behavior, and two new `analyze` lint rules) - see project memory for links. Backend + UI test audit: Reviewed the full test suite (backend unit + integration tests, UI unit and e2e tests) against a "locks in a real invariant" bar. Strengthened tests that covered real behavior weakly (cron next-fire assertions that would pass for a broken matcher, a payload-preservation test that never read the payload back, frame-length tests that exercised the standard library instead of the production decoder) rather than deleting them. Removed tests that didn't lock in any invariant: struct-echo/constructor- only tests, compile-only "the constant exists" checks, source-text-grep assertions on doc comments and identifiers, exact/near duplicates, empty placeholders, and one fully dead benchmark module (src/domains/notice/bench.rs) nothing in src/ or benches/ actually used. Verified: cargo check --workspace --all-targets, cargo clippy --all-targets (clean), cargo test --lib (1399 passed), every touched integration test binary, tsc --noEmit, full UI vitest suite (142 passed), and playwright test --list on the edited specs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cargo check --workspace --all-targetscargo clippy --all-targetscargo test --lib(1,399 passed)npm run type-checknpm run test(142 passed)npx playwright test --listfor edited specsAI assistance disclosure
AI tools assisted with audit and review. The maintainer remains responsible for the complete change and its validation.