Skip to content

fix: harden Lease acquisition disconnect handling - #2

Merged
smiggleworth merged 1 commit into
mainfrom
fix/lease-acquire-disconnect-safety
Aug 25, 2026
Merged

fix: harden Lease acquisition disconnect handling#2
smiggleworth merged 1 commit into
mainfrom
fix/lease-acquire-disconnect-safety

Conversation

@smiggleworth

Copy link
Copy Markdown
Contributor

Summary

  • allocate deferred Lease acquisition futures only for positive waits
  • observe internal deferred failures immediately so disconnect cannot produce an unretrieved future exception
  • remove stale waiters deterministically while preserving the public transport failure and cancellation behavior
  • export Schedule ERR_BACKEND_ERROR (7010) and classify it as retryable for replay-safe operations

This is the Python parity companion to cntryl/fitz-ts#22. Stream envelopes and bounded subscription delivery already matched the intended behavior.

Validation

  • Ruff format and lint
  • Pyright
  • 106 unit tests with branch coverage above 70 percent
  • source distribution and wheel build
  • 8 broker integration tests
  • four-leg TCP/WebSocket and anonymous/valid-JWT conformance matrix

Copilot AI lite review requested due to automatic review settings August 25, 2026 14:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@smiggleworth
smiggleworth merged commit 698213a into main Aug 25, 2026
12 checks passed
@smiggleworth
smiggleworth deleted the fix/lease-acquire-disconnect-safety branch August 25, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants