feat(lease): add patterned inventory observation - #11
Open
smiggleworth wants to merge 1 commit into
Open
Conversation
smiggleworth
force-pushed
the
lease-patterned-subscribe-and-list
branch
from
August 31, 2026 19:15
3b0900f to
122aaa7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you making this contribution?
The coordinated Lease inventory contract in cntryl/fitz#219 requires Go consumers of the public
fitzpackage to list patterned held-lease state and use a race-safe observer. Review found that the initial LIST implementation was internal-only and that async notification dispatch left a bootstrap installation race.Related issue
Part of cntryl/fitz#219. Broker counterpart: cntryl/fitz#221.
What does this change do?
fitz.LeaseClientadapter, including public 5011/5012 errors.**selector compositions while rejecting adjacent**locally.Validation
gofmt -d .go vet ./...go test ./... -timeout 120sgo test -race ./... -timeout 180sRisk and compatibility
The public API is additive and existing exact Lease mutation operations remain exact-only. LIST requires cntryl/fitz#221. Observers intentionally perform full LIST reconciliation after invalidations and periodically, so broad selectors trade higher read cost for convergence and must be closed when no longer needed.
Tool assistance disclosure
Select exactly one:
OpenAI Codex assisted with implementation, cross-repository review, regression-test construction, and validation orchestration. I reviewed the complete diff and exercised the repository gates and focused Lease scenarios.
Contributor responsibility